From: Michael Ellerman <michael@ellerman.id.au>
To: Pekka Enberg <penberg@kernel.org>
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails
Date: Mon, 06 Feb 2012 22:35:42 +1100 [thread overview]
Message-ID: <1328528142.16176.0.camel@concordia> (raw)
In-Reply-To: <alpine.LFD.2.02.1202061219280.1790@tux.localdomain>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Mon, 2012-02-06 at 12:22 +0200, Pekka Enberg wrote:
> On Mon, 6 Feb 2012, Michael Ellerman wrote:
> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> > index 95d35a5..569246e 100644
> > --- a/tools/kvm/builtin-run.c
> > +++ b/tools/kvm/builtin-run.c
> > @@ -997,6 +997,11 @@ static int kvm_cmd_run_init(int argc, const char **argv)
> > }
> >
> > kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name);
> > + if (IS_ERR(kvm)) {
> > + r = PTR_ERR(kvm);
> > + pr_err("kvm__init() failed with error %d\n", r);
> > + goto fail;
> > + }
> >
>
> I just pushed commit 3dfcb6ec85d5430622c8b99ca05451c1afd08bf5 ("kvm tool:
> Don't close not yet opened files and SIGSEV fix") from Cyrillos which was
> which seems to fix both issues. I was flying back from FOSDEM so I
> couldn't merge it earlier, sorry.
No stress, it's fixed is what matters :)
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-06 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 3:09 [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails Michael Ellerman
2012-02-06 3:09 ` [PATCH 2/2] kvm tool: Initialise kvm fd's to -1 in kvm__new() Michael Ellerman
2012-02-06 10:22 ` [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails Pekka Enberg
2012-02-06 10:27 ` Cyrill Gorcunov
2012-02-06 11:35 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328528142.16176.0.camel@concordia \
--to=michael@ellerman.id.au \
--cc=gorcunov@openvz.org \
--cc=kvm@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox