From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH 0/2] Fix build on i386 due to the latest tsc changes
Date: Thu, 16 Feb 2012 15:48:01 +0200 [thread overview]
Message-ID: <1329400083-22070-1-git-send-email-avi@redhat.com> (raw)
The code fixed by the second patch looks suspect though:
nsdiff = data - kvm->arch.last_tsc_write;
nsdiff = (nsdiff * 1000) / vcpu->arch.virtual_tsc_khz;
before the division, nsdiff is in tsc units. Dividing it by
tsc_khz/1000 is equivalent to multiplying it by 1000000 and dividing it by
tsc_hz, so the result is in units of mega-seconds. I expect we want
nsdiff /= (u64)tsc_khz * 1000;
(which is somewhat hard on i386)
Avi Kivity (2):
KVM: Fix 64-bit division in kvm_set_tsc_khz()
KVM: Fix 64-bit division in kvm_write_tsc()
arch/x86/kvm/x86.c | 18 ++++++++++++++++--
1 files changed, 16 insertions(+), 2 deletions(-)
--
1.7.9
next reply other threads:[~2012-02-16 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:48 Avi Kivity [this message]
2012-02-16 13:48 ` [PATCH 1/2] KVM: Fix 64-bit division in kvm_set_tsc_khz() Avi Kivity
2012-02-16 13:48 ` [PATCH 2/2] KVM: Fix 64-bit division in kvm_write_tsc() Avi Kivity
2012-02-16 13:53 ` [PATCH 0/2] Fix build on i386 due to the latest tsc changes Avi Kivity
2012-02-18 12:46 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329400083-22070-1-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox