Re: [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on migration

Eduardo Habkost
2016-12-12T18:01:07Z

On Sat, Dec 10, 2016 at 03:21:50PM -0200, Marcelo Tosatti wrote:
[...]
> static void kvmclock_realize(DeviceState *dev, Error **errp)
> {
> KVMClockState *s = KVM_CLOCK(dev);
>
> + if (kvm_has_adjust_clock_stable()) {
> + s->clock_is_reliable = true;
> + }
> +

This seems unnecessary, as kvmclock_vm_state_change() makes sure
it is set at the same time as s->clock. Should we just remove it?

> qemu_add_vm_change_state_handler(kvmclock_vm_state_change, s);
> }
>
[...]

--
Eduardo