From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] kvm: set gsi_bits and max_gsi correctly Date: Wed, 28 Mar 2012 12:20:20 -0600 Message-ID: <1332958820.3799.32.camel@bling.home> References: <201203281818.q2SII5ng021559@int-mx11.intmail.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, jan.kiszka@siemens.com To: Jason Baron Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932411Ab2C1SU3 (ORCPT ); Wed, 28 Mar 2012 14:20:29 -0400 In-Reply-To: <201203281818.q2SII5ng021559@int-mx11.intmail.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote: > The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap > correctly, and as a consequence pins max_gsi to 32 when it really > should be 1024. I ran into this limitation while testing pci > passthrough, where I consistently got an -ENOSPC return from > kvm_get_irq_route_gsi() called from assigned_dev_update_msix_mmio(). > > Signed-off-by: Jason Baron > --- > kvm-all.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index ab88c7c..b616c7d 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -873,7 +873,7 @@ static void kvm_init_irq_routing(KVMState *s) > unsigned int gsi_bits, i; > > /* Round up so we can search ints using ffs */ > - gsi_bits = (gsi_count + 31) / 32; > + gsi_bits = ALIGN(gsi_count, 32); > s->used_gsi_bitmap = g_malloc0(gsi_bits / 8); > s->max_gsi = gsi_bits; > Acked-by: Alex Williamson