From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 2/2] KVM: PPC: Book3S: Call into C interrupt handlers
Date: Fri, 27 Apr 2012 09:12:56 +1000
Message-ID: <1335481976.21961.87.camel@pasglop>
References: <1335435543-19690-1-git-send-email-agraf@suse.de>
	 <1335435543-19690-2-git-send-email-agraf@suse.de>
	 <1335476747.21961.82.camel@pasglop>
	 <4054E139-FF68-471B-B69C-9F76D75CA451@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: kvm list <kvm@vger.kernel.org>, kvm-ppc <kvm-ppc@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <4054E139-FF68-471B-B69C-9F76D75CA451@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Fri, 2012-04-27 at 00:24 +0200, Alexander Graf wrote:
> 
> This is to actually enable interrupts for real, regardless of ppc64
> and ppc32. In fact, the previous code was pretty buggy - it was
> running the handlers with interrupts disabled ;). 

They should be run with interrupts disabled.. tho both soft & hard.

You probably do want to call local_irq_disable() unconditionally anyway,
because on ppc32, that will give you the proper accounting vs. lockdep.

Cheers,
Ben.