From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, kvm-ppc <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs
Date: Fri, 11 May 2012 07:43:35 +1000 [thread overview]
Message-ID: <1336686215.3881.56.camel@pasglop> (raw)
In-Reply-To: <4FAC0118.9040908@redhat.com>
On Thu, 2012-05-10 at 20:55 +0300, Avi Kivity wrote:
> On 05/10/2012 08:49 PM, Alexander Graf wrote:
> >> +#if defined(TARGET_PPC64)
> >> + if (def->sps)
> >> + memcpy(&env->sps, def->sps, sizeof(*def->sps));
> >
> >
> > I never know if *def->... would dereference def or the complete
> > construct.
>
> 'man operator'
>
> > How about sizeof(env->sps)?
>
> How about
>
> env->sps = *def->sps;
Yeah, latter looks better doesn't it ? :-)
I'll change that when I respin.
Cheers,
Ben.
next prev parent reply other threads:[~2012-05-10 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 5:43 [PATCH] kvm/powerpc: Add new ioctl to retreive server MMU infos Benjamin Herrenschmidt
2012-04-27 5:51 ` [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs Benjamin Herrenschmidt
2012-05-10 17:49 ` Alexander Graf
2012-05-10 17:55 ` Avi Kivity
2012-05-10 21:43 ` Benjamin Herrenschmidt [this message]
2012-04-27 5:51 ` [PATCH 2/2] pseries: Correctly create ibm,segment-page-sizes property Benjamin Herrenschmidt
2012-05-10 17:57 ` Alexander Graf
2012-05-10 21:49 ` Benjamin Herrenschmidt
2012-05-03 8:09 ` [PATCH] kvm/powerpc: Add new ioctl to retreive server MMU infos Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2012-06-19 5:56 [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs Benjamin Herrenschmidt
2012-06-19 20:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336686215.3881.56.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox