Re: [PATCH v2 13/15] net: Remove obsolete vlan info

Jan Kiszka
2012-05-23T15:41:25Z

On 2012-05-23 12:14, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> net.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index 61dc28d..8c8e703 100644
> --- a/net.c
> +++ b/net.c
> @@ -1079,7 +1079,6 @@ void do_info_network(Monitor *mon)
> NetClientState *nc, *peer;
> net_client_type type;
>
> - monitor_printf(mon, "Devices not on any VLAN:\n");
> QTAILQ_FOREACH(nc, &net_clients, next) {
> peer = nc->peer;
> type = nc->info->type;

This looks suspicious - or the patch description is improvable. This is
really just about removing that headline? And what about the indention
of the lines printed afterward?

It also leads me to the question how hub-based networks will be
visualized on "info network", specifically when there are multiple hubs.
Can you provide some more complex example of an info network output?

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux