From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 2/2] Device assignment: Fix MSI IRQ affinity setting Date: Thu, 24 May 2012 17:23:48 -0600 Message-ID: <1337901828.4714.82.camel@ul30vt> References: <1337878924-39069-1-git-send-email-richard@nod.at> <1337878924-39069-2-git-send-email-richard@nod.at> <1337883627.4714.32.camel@ul30vt> <4FBEADCB.2010900@siemens.com> <1337897506.4714.55.camel@ul30vt> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Richard Weinberger , kvm@vger.kernel.org, avi@redhat.com, Marcelo Tosatti , Bjorn Helgaas , "Michael S. Tsirkin" To: Thomas Gleixner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14132 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759500Ab2EXXYH (ORCPT ); Thu, 24 May 2012 19:24:07 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2012-05-25 at 01:01 +0200, Thomas Gleixner wrote: > So the proper fix is that qemu tells the guest that mask bit is > supported and catches the mask bit toggling before writing it out to > the hardware for those devices which do not support it. We can't necessarily do that, we have to work with the config space we're give. Using the smallest possible MSI capability always works. Adding mask bits may not fit in with the existing capabilities of the physical device. Thanks, Alex