Re: Request VFIO inclusion in linux-next

Dan Carpenter
2012-06-28T06:44:08Z

On Wed, Jun 27, 2012 at 01:23:23PM -0600, Alex Williamson wrote:
> On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote:
> > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote:
> > > Hi,
> > >
> > > VFIO has been kicking around for well over a year now and has been
> > > posted numerous times for review. The pre-requirements are finally
> > > available in linux-next (or will be in the 20120626 build) so I'd like
> > > to request a new branch be included in linux-next with a goal of being
> > > accepted into v3.6.
> > >
> >
> > Could you run Sparse over the driver?
> > http://lwn.net/Articles/205624/
> >
> > It reports a bunch of endian problems. Some are definitely bugs
> > like:
> > *prev |= cpu_to_le32((u32)epos << 20);
>
> Done. Mostly just adding annotation, but it did find a bug or two.
> Should be cleaned up in tomorrow's next. Thanks for the report,
>

Cool. I have some Smatch fixes as well. I've updated them to apply
on top of today's linux-next.

regards,
dan carpenter