From: Joe Perches <joe@perches.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Joerg Roedel <joerg.roedel@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] kvm: Use pr_<level>
Date: Wed, 27 Jun 2012 18:34:41 -0700 [thread overview]
Message-ID: <1340847281.16533.57.camel@joe2Laptop> (raw)
In-Reply-To: <20120628004434.GA18388@amt.cnet>
On Wed, 2012-06-27 at 21:44 -0300, Marcelo Tosatti wrote:
> The advantage is the added prefix?
All messages are automatically prefixed.
For instance:
> > - printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
> > + pr_warn("Fail to find correlated MSI-X entry!\n");
Now has a prefix that describes the module from which
the message originates.
> $ grep limit Documentation/CodingStyle
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.
Read further:
However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
cheers, Joe
prev parent reply other threads:[~2012-06-28 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 3:20 [PATCH next] kvm: Use pr_<level> Joe Perches
2012-06-28 0:44 ` Marcelo Tosatti
2012-06-28 1:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340847281.16533.57.camel@joe2Laptop \
--to=joe@perches.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox