From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH next] kvm: Use pr_<level>
Date: Wed, 27 Jun 2012 18:34:41 -0700
Message-ID: <1340847281.16533.57.camel@joe2Laptop>
References: <1339644021.28729.17.camel@joe2Laptop>
	 <20120628004434.GA18388@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Joerg Roedel <joerg.roedel@amd.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20120628004434.GA18388@amt.cnet>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, 2012-06-27 at 21:44 -0300, Marcelo Tosatti wrote:
> The advantage is the added prefix?

All messages are automatically prefixed.
For instance:

> > -		printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
> > +		pr_warn("Fail to find correlated MSI-X entry!\n");

Now has a prefix that describes the module from which
the message originates.

> $ grep limit Documentation/CodingStyle 
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.

Read further:

However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.

cheers, Joe