From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions Date: Fri, 29 Jun 2012 09:14:33 -0600 Message-ID: <1340982873.1207.335.camel@bling.home> References: <20120627044758.23698.249.stgit@bling.home> <20120627050858.23698.44118.stgit@bling.home> <20120627162430.3477d0f6@BR9GNB5Z> <20120628083857.GD12447@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Cornelia Huck , avi@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jan.kiszka@siemens.com To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20120628083857.GD12447@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, 2012-06-28 at 11:38 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2012 23:09:04 -0600 > > Alex Williamson wrote: > > > > > Prune this down to just the struct kvm_irqfd so we can avoid > > > changing function definition for every flag or field we use. > > > > > > Signed-off-by: Alex Williamson > > > > I'm currently trying to find a way to make irqfd workable for s390 > > which will likely include using a new field in kvm_irqfd, so I'd like > > to have this change (and I also think it makes the code nicer to read). > > So: > > > > Acked-by: Cornelia Huck > > Unfortunately it looks like we are not sanitizing kvm_irqfd > at all so we won't be able to use the padding :( > We'll need a new ioctl instead. I think you're jumping the gun on this decision.