From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] pseries: Add support for new KVM hash table control call
Date: Tue, 10 Jul 2012 17:25:38 +1000
Message-ID: <1341905138.2561.12.camel@pasglop>
References: <1340799048.3732.55.camel@pasglop>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org,
	kvm@vger.kernel.org
To: qemu-devel@nongnu.org
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <1340799048.3732.55.camel@pasglop>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson <david@gibson.dropbear.id.au>
> 
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
> 
> This also paves the way for indicating a different size hash table
> to the kernel and for the kernel to be able to impose limits on
> the requested size.

Alex, this has a bug, if you already applied it, please sneak:

> +int kvmppc_reset_htab(int shift_hint)
> +{
> +    uint32_t shift = shift_hint;
> +
> +    if (kvm_check_extension(kvm_state, KVM_CAP_PPC_ALLOC_HTAB)) {

The above shall be if (kvm_enabled() && ....

Else it will segfault in kvm_check_extension

Or let me know if I should re-submit.

Cheers,
Ben.