From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver Date: Wed, 18 Jul 2012 14:20:58 -0700 Message-ID: <1342646458.18004.637.camel@haakon2.linux-iscsi.org> References: <1342573172-17421-1-git-send-email-nab@linux-iscsi.org> <1342573172-17421-5-git-send-email-nab@linux-iscsi.org> <20120718160919.GA2152@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: target-devel , linux-scsi , lf-virt , kvm-devel , Stefan Hajnoczi , Zhi Yong Wu , Anthony Liguori , Paolo Bonzini , Christoph Hellwig , Jens Axboe , Hannes Reinecke , Greg Kroah-Hartman To: "Michael S. Tsirkin" Return-path: Received: from mail.linux-iscsi.org ([67.23.28.174]:38176 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753643Ab2GRVVA (ORCPT ); Wed, 18 Jul 2012 17:21:00 -0400 In-Reply-To: <20120718160919.GA2152@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 12:59:32AM +0000, Nicholas A. Bellinger wrote: > > > > Changelog v2 -> v3: > > > > Unlock on error in tcm_vhost_drop_nexus() (DanC) > > Fix strlen() doesn't count the terminator (DanC) > > Call kfree() on an error path (DanC) > > Convert tcm_vhost_write_pending to use target_execute_cmd (hch + nab) > > Fix another strlen() off by one in tcm_vhost_make_tport (DanC) > > Add option under drivers/staging/Kconfig, and move to drivers/vhost/tcm/ > > as requested by MST (nab) > > > > --- > > drivers/staging/Kconfig | 2 + > > drivers/vhost/Makefile | 2 + > > drivers/vhost/tcm/Kconfig | 6 + > > drivers/vhost/tcm/Makefile | 1 + > > drivers/vhost/tcm/tcm_vhost.c | 1611 +++++++++++++++++++++++++++++++++++++++++ > > drivers/vhost/tcm/tcm_vhost.h | 74 ++ > > 6 files changed, 1696 insertions(+), 0 deletions(-) > > create mode 100644 drivers/vhost/tcm/Kconfig > > create mode 100644 drivers/vhost/tcm/Makefile > > create mode 100644 drivers/vhost/tcm/tcm_vhost.c > > create mode 100644 drivers/vhost/tcm/tcm_vhost.h > > > > Really sorry about making you run around like that, > I did not mean moving all of tcm to a directory, > just adding tcm/Kconfig or adding drivers/vhost/Kconfig.tcm > because eventually it's easier to keep it all together > in one place. > Er, apologies for the slight mis-understanding here.. Moving back now + fixing up the Kbuild bits.