From: Michael Ellerman <michael@ellerman.id.au>
To: <penberg@kernel.org>
Cc: <kvm@vger.kernel.org>
Subject: [PATCH 1/2] kvm tools: Fix formatting of error message in TAP handling
Date: Fri, 10 Aug 2012 15:38:51 +1000 [thread overview]
Message-ID: <1344577132-19796-1-git-send-email-michael@ellerman.id.au> (raw)
This error message is missing a space, and has a redundant ":" at the end,
currently it produces:
You have requested a TAP device, but creation of one hasfailed because:: No such file or directory
Add a space to "hasfailed" and remove the extra ":".
Don't split the line to improve grepability.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
tools/kvm/virtio/net.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c
index 10420ae..8f3735b 100644
--- a/tools/kvm/virtio/net.c
+++ b/tools/kvm/virtio/net.c
@@ -526,8 +526,7 @@ void virtio_net__init(const struct virtio_net_params *params)
ndev->mode = params->mode;
if (ndev->mode == NET_MODE_TAP) {
if (!virtio_net__tap_init(params, ndev))
- die_perror("You have requested a TAP device, but creation of one has"
- "failed because:");
+ die_perror("You have requested a TAP device, but creation of one has failed because");
ndev->ops = &tap_ops;
} else {
ndev->info.host_ip = ntohl(inet_addr(params->host_ip));
--
1.7.9.5
next reply other threads:[~2012-08-10 5:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 5:38 Michael Ellerman [this message]
2012-08-10 5:38 ` [PATCH 2/2] kvm tools: Check for unknown parameters in network option handling Michael Ellerman
2012-08-11 0:21 ` Asias He
2012-08-13 3:31 ` Michael Ellerman
2012-08-13 7:27 ` Pekka Enberg
2012-08-14 1:27 ` Asias He
2012-08-10 23:58 ` [PATCH 1/2] kvm tools: Fix formatting of error message in TAP handling Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344577132-19796-1-git-send-email-michael@ellerman.id.au \
--to=michael@ellerman.id.au \
--cc=kvm@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).