From mboxrd@z Thu Jan  1 00:00:00 1970
From: Davidlohr Bueso <dave@gnu.org>
Subject: Re: [PATCH] KVM: VMX: invalidate vpid for invlpg instruction
Date: Mon, 03 Sep 2012 01:27:20 +0200
Message-ID: <1346628440.3170.3.camel@offbook>
References: <1346429448.2823.1.camel@offbook>
	 <20120831173707.GA3895@amt.cnet>
Reply-To: dave@gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, KVM <kvm@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from caiajhbdcahe.dreamhost.com ([208.97.132.74]:49379 "EHLO
	homiemail-a62.g.dreamhost.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754827Ab2IBX1Y (ORCPT
	<rfc822;kvm@vger.kernel.org>); Sun, 2 Sep 2012 19:27:24 -0400
In-Reply-To: <20120831173707.GA3895@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, 2012-08-31 at 14:37 -0300, Marcelo Tosatti wrote:
> On Fri, Aug 31, 2012 at 06:10:48PM +0200, Davidlohr Bueso wrote:
> > For processors that support VPIDs we should invalidate the page table entry
> > specified by the lineal address. For this purpose add support for individual
> > address invalidations.
> 
> Not necessary - a single context invalidation is performed through
> KVM_REQ_TLB_FLUSH.

Since vpid_sync_context() supports both single and all-context vpid
invalidations, wouldn't it make sense to also add individual address
ones as well, supporting further granularity?

> 
> Single-context. If the INVVPID type is 1, the logical processor
> invalidates all
> linear mappings and combined mappings associated with the VPID specified
> in the INVVPID descriptor.
> 
>