From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: PPC: Book3S: Implement floating-point state get/set functions
Date: Wed, 19 Sep 2012 13:37:42 +1000 [thread overview]
Message-ID: <1348025862.2386.63.camel@pasglop> (raw)
In-Reply-To: <C760C94D-2B91-42CB-9451-027D49F19229@suse.de>
On Fri, 2012-09-14 at 03:44 +0200, Alexander Graf wrote:
>
> We're slowly moving towards ONE_REG. ARM is already going full steam
> ahead and I'd like to have every new register in PPC be modeled with
> it as well. The old interface broke on us one time too often now :).
>
> As I said, if we run into performance problems, we will implement ways
> to improve performance. At the end of the day, x86 will be the odd one
> out.
This is totally insane. In most cases, we care about the whole set of 32
registers. Doing 32 ioctl's for that is just plain stupid.
There is nothing wrong in allowing the "one reg" interface as well, but
it's totally ridiculous to *require* it.
Ben.
next prev parent reply other threads:[~2012-09-19 3:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 0:17 [PATCH 0/2] KVM: PPC: Save/restore complete Book3S HV guest register state Paul Mackerras
2012-09-12 0:18 ` [PATCH 1/2] KVM: PPC: Book3S HV: Get/set guest SPRs using the GET/SET_ONE_REG interface Paul Mackerras
2012-09-13 23:29 ` Alexander Graf
2012-09-12 0:19 ` [PATCH 2/2] KVM: PPC: Book3S: Implement floating-point state get/set functions Paul Mackerras
2012-09-13 23:30 ` Alexander Graf
2012-09-13 23:58 ` Paul Mackerras
2012-09-14 0:03 ` Alexander Graf
2012-09-14 1:36 ` Paul Mackerras
2012-09-14 1:44 ` Alexander Graf
2012-09-14 1:50 ` Alexander Graf
2012-09-14 7:15 ` Paul Mackerras
2012-09-19 3:37 ` Benjamin Herrenschmidt [this message]
2012-09-19 8:45 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348025862.2386.63.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox