From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [RFC PATCH] KVM: PPC: Remove 44x target
Date: Mon, 8 Oct 2012 15:50:03 -0500
Message-ID: <1349729403.3721.7@snotra>
References: <1349618282-32227-1-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Transfer-Encoding: 8BIT
Cc: <kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>,
	Tirumala Marri <tmarri@apm.com>,
	Jim Johnston <jjohnston@apm.com>,
	Richard Zenkert <rzenkert@apm.com>,
	Scarlett Smith <slsmith@apm.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <1349618282-32227-1-git-send-email-agraf@suse.de> (from
	agraf@suse.de on Sun Oct  7 08:58:02 2012)
Content-Disposition: inline
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 10/07/2012 08:58:02 AM, Alexander Graf wrote:
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S  
> b/arch/powerpc/kvm/bookehv_interrupts.S
> index 099fe82..4421293 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -23,7 +23,6 @@
>  #include <asm/ppc_asm.h>
>  #include <asm/kvm_asm.h>
>  #include <asm/reg.h>
> -#include <asm/mmu-44x.h>
>  #include <asm/page.h>
>  #include <asm/asm-compat.h>
>  #include <asm/asm-offsets.h>

This could come out of here regardless of whether 44x stays.

> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index 7d120dc..f522110 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -158,10 +158,7 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu)
>  	}
>  	case KVM_HCALL_TOKEN(KVM_HC_FEATURES):
>  		r = EV_SUCCESS;
> -#if defined(CONFIG_PPC_BOOK3S) || defined(CONFIG_KVM_E500V2)
> -		/* XXX Missing magic page on 44x */
>  		r2 |= (1 << KVM_FEATURE_MAGIC_PAGE);
> -#endif

We also don't support this on e500mc -- or at least it hasn't been  
tested, and would be pretty pointless nothing in the magic page traps  
on e500mc.

-Scott