From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [kvmarm] [RFC PATCH 0/3] KVM: ARM: Get rid of hardcoded VGIC
 addresses
Date: Thu, 18 Oct 2012 10:58:51 +1100
Message-ID: <1350518331.4678.114.camel@pasglop>
References: <1350173065-35350-1-git-send-email-c.dall@virtualopensystems.com>
	 <507F172D.2030802@suse.de>
	 <CANM98q+gfcp86zVV0B1t2aOKTftFegs6dk-+DNc-78LijueOiw@mail.gmail.com>
	 <20121017221022.GA4333@bloggs.ozlabs.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Christoffer Dall <c.dall@virtualopensystems.com>,
	Alexander Graf <agraf@suse.de>, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org, kvm-ppc <kvm-ppc@vger.kernel.org>
To: Paul Mackerras <paulus@samba.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20121017221022.GA4333@bloggs.ozlabs.ibm.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, 2012-10-18 at 09:10 +1100, Paul Mackerras wrote:
> 
> With the XICS, there are two types of irqchip: a source controller and
> a presentation controller.  There is one presentation controller per
> vcpu and typically one source controller per PCI host bridge (a source
> controller can manage multiple sources).  The "buid" above is
> basically an identifier for a source controller.
> 
> So with the above, it would be quite easy to add new types and
> arguments for them. 

The only possible issue is that afiak, the ioctl number depends on the
structure size, no ? If it does, then we should add some padding to the
union to leave room for new types.

Cheers,
Ben.