From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH for-1.3] vfio-pci: Fix KVM disabled path
Date: Fri, 30 Nov 2012 12:14:33 -0700
Message-ID: <1354302873.1809.246.camel@bling.home>
References: <20121127194314.2422.65587.stgit@bling.home>
	<CAFEAcA_hr2HLPTWq9pH4wk58mxrnVUjOHe4AXY-pbS0z9FjXAA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <CAFEAcA_hr2HLPTWq9pH4wk58mxrnVUjOHe4AXY-pbS0z9FjXAA@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On Fri, 2012-11-30 at 18:57 +0000, Peter Maydell wrote:
> On 27 November 2012 19:45, Alex Williamson <alex.williamson@redhat.com> wrote:
> > kvm_check_extension() explodes when KVM isn't enabled so we need to
> > first test whether KVM is enabled.  Use kvm_irqchip_in_kernel() for
> > this since it matches the test we do before using this result.
> 
> > --- a/hw/vfio_pci.c
> > +++ b/hw/vfio_pci.c
> > @@ -438,7 +438,8 @@ static int vfio_enable_intx(VFIODevice *vdev)
> >       * Only conditional to avoid generating error messages on platforms
> >       * where we won't actually use the result anyway.
> >       */
> > -    if (kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
> > +    if (kvm_irqchip_in_kernel() &&
> > +        kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
> >          vdev->intx.route = pci_device_route_intx_to_irq(&vdev->pdev,
> >                                                          vdev->intx.pin);
> 
> 
> vfio_pci is supposed to be architecture-independent code, right?
> kvm.h says you mustn't use kvm_irqchip_in_kernel() in such code
> (its semantics vary from arch to arch). I think kvm_enabled()
> is sufficient here since what we're actually guarding is just
> the kvm_check_extension call.

Here, yes.  The other call spot we're matching is specifically looking
for whether kvm is capable of using IRQFD_RESAMPLE and whether it should
be used.  I think kvm_irqfds_enabled() is probably the right way to go.
Post 1.3 we might want to make kvm_intx_via_irqfd_enabled which
encapsulates the IRQFD_RESAMPLE test.  I'll do some testing and repost a
kvm_irqfds_enabled() version.  Thanks,

Alex