From: Alex Williamson <alex.williamson@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/6] kvm: Merge id_to_index into memslots
Date: Wed, 05 Dec 2012 15:58:22 -0700 [thread overview]
Message-ID: <1354748302.3224.58.camel@bling.home> (raw)
In-Reply-To: <20121205212200.GB20260@amt.cnet>
On Wed, 2012-12-05 at 19:22 -0200, Marcelo Tosatti wrote:
> On Mon, Dec 03, 2012 at 04:39:24PM -0700, Alex Williamson wrote:
> > This allows us to resize this structure and therefore the number of
> > memslots as part of the RCU update.
>
> Why is this necessary? "struct memslots" is updated, message above
> conflicts with that.
>
> If there is a reason, "id_to_index" becomes confusing.
>
I can't have two indeterminate sized arrays in the same structure, so by
moving id_to_index into struct kvm_memory_slot I get back to one array.
I'm playing with whether this is worthwhile. If we reduce id_to_index
to a short then we can leave it with a static size and still get a
memory savings for the typical case. Thanks,
Alex
next prev parent reply other threads:[~2012-12-05 22:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 23:39 [RFC PATCH 0/6] kvm: Growable memory slot array Alex Williamson
2012-12-03 23:39 ` [RFC PATCH 1/6] kvm: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS Alex Williamson
2012-12-03 23:39 ` [RFC PATCH 2/6] kvm: Make KVM_PRIVATE_MEM_SLOTS optional Alex Williamson
2012-12-03 23:39 ` [RFC PATCH 3/6] kvm: Merge id_to_index into memslots Alex Williamson
2012-12-05 21:22 ` Marcelo Tosatti
2012-12-05 22:58 ` Alex Williamson [this message]
2012-12-03 23:39 ` [RFC PATCH 4/6] kvm: Move private memory slots to start of memslots array Alex Williamson
2012-12-05 21:24 ` Marcelo Tosatti
2012-12-05 22:58 ` Alex Williamson
2012-12-03 23:39 ` [RFC PATCH 5/6] kvm: Re-introduce memslots->nmemslots Alex Williamson
2012-12-05 21:26 ` Marcelo Tosatti
2012-12-05 23:02 ` Alex Williamson
2012-12-06 1:45 ` Marcelo Tosatti
2012-12-06 3:51 ` Alex Williamson
2012-12-06 23:58 ` Marcelo Tosatti
2012-12-06 23:59 ` Marcelo Tosatti
2012-12-07 0:07 ` Alex Williamson
2012-12-03 23:39 ` [RFC PATCH 6/6] kvm: Allow memory slots to grow Alex Williamson
2012-12-04 11:48 ` [RFC PATCH 0/6] kvm: Growable memory slot array Gleb Natapov
2012-12-04 15:21 ` Alex Williamson
2012-12-04 15:30 ` Gleb Natapov
2012-12-04 15:39 ` Alex Williamson
2012-12-04 16:42 ` Gleb Natapov
2012-12-04 17:56 ` Alex Williamson
2012-12-04 14:48 ` Takuya Yoshikawa
2012-12-04 15:26 ` Alex Williamson
2012-12-05 21:32 ` Marcelo Tosatti
2012-12-05 22:57 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354748302.3224.58.camel@bling.home \
--to=alex.williamson@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).