From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Zhang Subject: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Date: Wed, 12 Dec 2012 13:05:12 +0800 Message-ID: <1355288712-26899-1-git-send-email-yang.z.zhang@intel.com> Cc: gleb@redhat.com, Yang Zhang To: kvm@vger.kernel.org Return-path: Received: from mga14.intel.com ([143.182.124.37]:64036 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790Ab2LLFJl (ORCPT ); Wed, 12 Dec 2012 00:09:41 -0500 Sender: kvm-owner@vger.kernel.org List-ID: From: Yang Zhang This hack is wrong. The pin number of PIT is connected to 2 not 0. This means this hack never takes effect. So it is ok to remove it. Signed-off-by: Yang Zhang --- virt/kvm/ioapic.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index cfb7e4d..f3abbef 100644 --- a/virt/kvm/ioapic.c +++ b/virt/kvm/ioapic.c @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq) irqe.level = 1; irqe.shorthand = 0; -#ifdef CONFIG_X86 - /* Always delivery PIT interrupt to vcpu 0 */ - if (irq == 0) { - irqe.dest_mode = 0; /* Physical mode. */ - /* need to read apic_id from apic regiest since - * it can be rewritten */ - irqe.dest_id = ioapic->kvm->bsp_vcpu_id; - } -#endif return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe); } -- 1.7.1