Re: [PATCH 3/7] KVM: x86 emulator: introduce NoWrite flag

Avi Kivity
2012-12-22T15:28:01Z

On Sat, Dec 22, 2012 at 5:11 PM, Gleb Natapov <gleb@redhat.com> wrote:
>> #define X2(x...) x, x
>> #define X3(x...) X2(x), x
>> @@ -1584,6 +1585,9 @@ static int writeback(struct x86_emulate_ctxt *ctxt)
>> {
>> int rc;
>>
>> + if (ctxt->d & NoWrite)
>> + return X86EMUL_CONTINUE;
>> +
> Why not make it Dst flag and set dst.type to OP_NONE during decoding
> instead of this special case?

My thinking was to eventually convert everything to NoWrite, then it's
not a special case. But your approach works too, I can change it if
you like. We'll have an if () either way though.