From: Avi Kivity <avi.kivity@gmail.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH v3 0/7] Streamline arithmetic instruction emulation
Date: Fri, 4 Jan 2013 16:18:47 +0200 [thread overview]
Message-ID: <1357309134-11944-1-git-send-email-avi.kivity@gmail.com> (raw)
The current arithmetic instruction emulation is fairly clumsy: after
decode, each instruction gets a switch (size), and for every size
we fetch the operands, prepare flags, emulate the instruction, then store
back the flags and operands.
This patchset simplifies things by moving everything into common code
except the instruction itself. All the pre- and post- processing is
coded just once. The per-instrution code looks like:
add %bl, %al
ret
add %bx, %ax
ret
add %ebx, %eax
ret
add %rbx, %rax
ret
The savings in size, for the ten instructions converted in this patchset,
are fairly large:
text data bss dec hex filename
63724 0 0 63724 f8ec arch/x86/kvm/emulate.o.before
61268 0 0 61268 ef54 arch/x86/kvm/emulate.o.after
- around 2500 bytes.
v3: fix reversed operand order in 2-operand macro
v2: rebased
Avi Kivity (7):
KVM: x86 emulator: framework for streamlining arithmetic opcodes
KVM: x86 emulator: Support for declaring single operand fastops
KVM: x86 emulator: introduce NoWrite flag
KVM: x86 emulator: mark CMP, CMPS, SCAS, TEST as NoWrite
KVM: x86 emulator: convert NOT, NEG to fastop
KVM: x86 emulator: add macros for defining 2-operand fastop emulation
KVM: x86 emulator: convert basic ALU ops to fastop
arch/x86/kvm/emulate.c | 215 +++++++++++++++++++++++++++----------------------
1 file changed, 120 insertions(+), 95 deletions(-)
--
1.8.0.1
next reply other threads:[~2013-01-04 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 14:18 Avi Kivity [this message]
2013-01-04 14:18 ` [PATCH v3 1/7] KVM: x86 emulator: framework for streamlining arithmetic opcodes Avi Kivity
2013-01-04 14:18 ` [PATCH v3 2/7] KVM: x86 emulator: Support for declaring single operand fastops Avi Kivity
2013-01-04 14:18 ` [PATCH v3 3/7] KVM: x86 emulator: introduce NoWrite flag Avi Kivity
2013-01-04 14:18 ` [PATCH v3 4/7] KVM: x86 emulator: mark CMP, CMPS, SCAS, TEST as NoWrite Avi Kivity
2013-01-04 14:18 ` [PATCH v3 5/7] KVM: x86 emulator: convert NOT, NEG to fastop Avi Kivity
2013-01-04 14:18 ` [PATCH v3 6/7] KVM: x86 emulator: add macros for defining 2-operand fastop emulation Avi Kivity
2013-01-04 14:18 ` [PATCH v3 7/7] KVM: x86 emulator: convert basic ALU ops to fastop Avi Kivity
2013-01-08 11:38 ` [PATCH v3 0/7] Streamline arithmetic instruction emulation Gleb Natapov
2013-01-10 17:33 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357309134-11944-1-git-send-email-avi.kivity@gmail.com \
--to=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox