public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: KVM list <kvm@vger.kernel.org>
Subject: [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests
Date: Fri,  4 Jan 2013 18:36:37 +0100	[thread overview]
Message-ID: <1357321000-31008-2-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1357321000-31008-1-git-send-email-agraf@suse.de>

When injecting an interrupt into guest context, we usually don't need
to check for requests anymore. At least not until today.

With the introduction of EPR, we will have to create a request when the
guest has successfully accepted an external interrupt though.

So we need to prepare the interrupt delivery to abort guest entry
gracefully. Otherwise we'd delay the EPR request.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/booke.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 69f1140..4ae83f9 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -554,14 +554,16 @@ static void update_timer_ints(struct kvm_vcpu *vcpu)
 		kvmppc_core_dequeue_watchdog(vcpu);
 }
 
-static void kvmppc_core_check_exceptions(struct kvm_vcpu *vcpu)
+static int kvmppc_core_check_exceptions(struct kvm_vcpu *vcpu)
 {
 	unsigned long *pending = &vcpu->arch.pending_exceptions;
 	unsigned int priority;
+	int r = 0;
 
 	priority = __ffs(*pending);
 	while (priority < BOOKE_IRQPRIO_MAX) {
-		if (kvmppc_booke_irqprio_deliver(vcpu, priority))
+		r = kvmppc_booke_irqprio_deliver(vcpu, priority);
+		if (r)
 			break;
 
 		priority = find_next_bit(pending,
@@ -571,15 +573,19 @@ static void kvmppc_core_check_exceptions(struct kvm_vcpu *vcpu)
 
 	/* Tell the guest about our interrupt status */
 	vcpu->arch.shared->int_pending = !!*pending;
+
+	return r > 1;
 }
 
 /* Check pending exceptions and deliver one, if possible. */
 int kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu)
 {
-	int r = 0;
+	int r;
 	WARN_ON_ONCE(!irqs_disabled());
 
-	kvmppc_core_check_exceptions(vcpu);
+	r = kvmppc_core_check_exceptions(vcpu);
+	if (r)
+		return r;
 
 	if (vcpu->arch.shared->msr & MSR_WE) {
 		local_irq_enable();
-- 
1.6.0.2


  reply	other threads:[~2013-01-04 17:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 17:36 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support Alexander Graf
2013-01-04 17:36 ` Alexander Graf [this message]
2013-01-04 19:40   ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Scott Wood
2013-01-04 23:02     ` Alexander Graf
2013-01-04 17:36 ` [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Alexander Graf
2013-01-04 19:50   ` Scott Wood
2013-01-04 23:11     ` Alexander Graf
2013-01-04 17:36 ` [PATCH 3/4] KVM: PPC: BookE: Implement EPR exit Alexander Graf
2013-01-04 20:19   ` Scott Wood
2013-01-04 17:36 ` [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Alexander Graf
2013-01-04 20:08   ` Scott Wood
2013-01-04 22:55     ` Alexander Graf
2013-01-04 23:03       ` Scott Wood
2013-01-04 23:06         ` Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2013-01-04 23:41 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v2 Alexander Graf
2013-01-04 23:41 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf
2013-01-07 19:38 [PATCH 0/4] KVM: PPC: BookE: Add EPR user space support v3 Alexander Graf
2013-01-07 19:38 ` [PATCH 1/4] KVM: PPC: BookE: Allow irq deliveries to inject requests Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357321000-31008-2-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox