From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 2/4] KVM: PPC: BookE: Emulate mfspr on EPR Date: Fri, 4 Jan 2013 13:50:19 -0600 Message-ID: <1357329019.666.14@snotra> References: <1357321000-31008-1-git-send-email-agraf@suse.de> <1357321000-31008-3-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: , KVM list To: Alexander Graf Return-path: In-Reply-To: <1357321000-31008-3-git-send-email-agraf@suse.de> (from agraf@suse.de on Fri Jan 4 11:36:38 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/04/2013 11:36:38 AM, Alexander Graf wrote: > The EPR register is potentially valid for PR KVM as well, so we need > to emulate accesses to it. It's only defined for reading, so only > handle the mfspr case. > > Signed-off-by: Alexander Graf > --- > arch/powerpc/kvm/booke_emulate.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kvm/booke_emulate.c > b/arch/powerpc/kvm/booke_emulate.c > index 4685b8c..27a4b28 100644 > --- a/arch/powerpc/kvm/booke_emulate.c > +++ b/arch/powerpc/kvm/booke_emulate.c > @@ -269,6 +269,9 @@ int kvmppc_booke_emulate_mfspr(struct kvm_vcpu > *vcpu, int sprn, ulong *spr_val) > case SPRN_ESR: > *spr_val = vcpu->arch.shared->esr; > break; > + case SPRN_EPR: > + *spr_val = vcpu->arch.epr; > + break; It's not just potentially valid -- in our internal tree we do paravirt EPR on e500v2 even though the hardware doesn't implement it. -Scott