From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 4/4] KVM: PPC: BookE: Add EPR ONE_REG sync Date: Fri, 4 Jan 2013 17:03:03 -0600 Message-ID: <1357340583.666.21@snotra> References: <1357330099.666.15@snotra> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: , KVM list To: Alexander Graf Return-path: In-Reply-To: (from agraf@suse.de on Fri Jan 4 16:55:34 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/04/2013 04:55:34 PM, Alexander Graf wrote: > > On 04.01.2013, at 21:08, Scott Wood wrote: > > > On 01/04/2013 11:36:40 AM, Alexander Graf wrote: > >> We need to be able to read and write the contents of the EPR > register > >> from user space. > >> This patch implements that logic through the ONE_REG API and > declares > >> its (never implemented) SREGS counterpart as deprecated. > > > > QEMU already uses SREGS to read this... I'm not sure what happened > on the KVM side. > > Since it's never been implemented on the KVM side, I don't see why > it'd be an issue to force ONE_REG on any user :). In the long run, > I'd like to move as much of the state synchronization to ONE_REG. That's fine -- but we should make sure not to forget to update QEMU. -Scott