From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: <kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/3] KVM: PPC: e500: Call kvmppc_mmu_map for initial mapping
Date: Thu, 17 Jan 2013 18:35:34 -0600 [thread overview]
Message-ID: <1358469334.13978.20@snotra> (raw)
In-Reply-To: <6F53F898-0DF7-4CBD-8204-1A34F2E82D6E@suse.de> (from agraf@suse.de on Thu Jan 17 18:29:56 2013)
On 01/17/2013 06:29:56 PM, Alexander Graf wrote:
>
> On 18.01.2013, at 01:20, Alexander Graf wrote:
>
> >
> > On 18.01.2013, at 01:11, Scott Wood wrote:
> >
> >> It also seems like it would be cleaner to just invalidate the old
> entry
> >> in tlbwe, and then this function doesn't need to change at all. I
> am a
> >> bit confused by how invalidation is currently operating
>
> Well, this bit is obvious. It's done by kvmppc_e500_shadow_map when
> it calls kvmppc_e500_ref_release(), right?
>
> Why it's not done explicitly though is a really good question :).
Yeah, I saw that but considered it (in combination with not reaching
this function if the gtlbe is invalid, and with always preloading the
host entry when the guest does tlbwe) to be why we're getting away with
it rather than why it was done that way.
-Scott
next prev parent reply other threads:[~2013-01-18 0:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 22:50 [PATCH 0/3] KVM: PPC: e500: Shadow TLB Improvements Alexander Graf
2013-01-17 22:50 ` [PATCH 1/3] KVM: PPC: e500: Call kvmppc_mmu_map for initial mapping Alexander Graf
2013-01-18 0:11 ` Scott Wood
2013-01-18 0:20 ` Alexander Graf
2013-01-18 0:29 ` Alexander Graf
2013-01-18 0:35 ` Scott Wood [this message]
2013-01-18 0:47 ` Scott Wood
2013-01-18 0:49 ` Alexander Graf
2013-01-18 1:16 ` Alexander Graf
2013-01-17 22:50 ` [PATCH 2/3] KVM: PPC: E500: Split host and guest MMU parts Alexander Graf
2013-01-17 22:50 ` [PATCH 3/3] KVM: PPC: e500: Implement TLB1-in-TLB0 mapping Alexander Graf
2013-01-18 0:31 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358469334.13978.20@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox