From: Scott Wood <scottwood@freescale.com>
To: Stuart Yoder <stuart.yoder@freescale.com>
Cc: <agraf@suse.de>, <benh@kernel.crashing.org>,
<linuxppc-dev@ozlabs.org>, <kvm-ppc@vger.kernel.org>,
<kvm@vger.kernel.org>, Stuart Yoder <stuart.yoder@freescale.com>
Subject: Re: [PATCH][v2] KVM: PPC: add paravirt idle loop for 64-bit book E
Date: Thu, 24 Jan 2013 12:22:20 -0600 [thread overview]
Message-ID: <1359051740.24865.10@snotra> (raw)
In-Reply-To: <1358898883-16218-1-git-send-email-stuart.yoder@freescale.com> (from stuart.yoder@freescale.com on Tue Jan 22 17:54:43 2013)
On 01/22/2013 05:54:43 PM, Stuart Yoder wrote:
> +.macro BOOK3E_IDLE_LOOP
> +1:
> + PPC_WAIT(0)
> b 1b
> +.endm
> +
> +.macro EPAPR_EV_IDLE_LOOP
> +idle_loop:
> + LOAD_REG_IMMEDIATE(r11, EV_HCALL_TOKEN(EV_IDLE))
> +
> +.global epapr_ev_idle_start
> +epapr_ev_idle_start:
> + li r3, -1
> + nop
> + nop
> + nop
> + b idle_loop
> +.endm
> +
> +BOOK3E_IDLE epapr_ev_idle, EPAPR_EV_IDLE_LOOP
> +
> +BOOK3E_IDLE book3e_idle BOOK3E_IDLE_LOOP
Why the comma after epapr_ev_idle but not after book3e_idle?
Also you have spaces where there should be tabs.
Otherwise looks good.
-Scott
next prev parent reply other threads:[~2013-01-24 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 23:54 [PATCH][v2] KVM: PPC: add paravirt idle loop for 64-bit book E Stuart Yoder
2013-01-24 17:42 ` Alexander Graf
2013-01-24 18:22 ` Scott Wood [this message]
2013-01-24 18:26 ` Yoder Stuart-B08248
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359051740.24865.10@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox