From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 8/8] KVM:PPC:booke: Allow debug interrupt injection to
 guest
Date: Thu, 31 Jan 2013 12:03:26 -0600
Message-ID: <1359655406.31540.1@snotra>
References: <1358324685-30225-1-git-send-email-bharat.bhushan@freescale.com>
	<1358324685-30225-7-git-send-email-bharat.bhushan@freescale.com>
	<4145C65C-BC91-494C-8C90-2DC2538F131F@suse.de>
	<6A3DF150A5B70D4F9B66A25E3F7C888D065829EE@039-SN2MPN1-022.039d.mgd>
	<11819845-A3C0-41F1-90E3-8E22E97863CB@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Transfer-Encoding: 8BIT
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <11819845-A3C0-41F1-90E3-8E22E97863CB@suse.de> (from
	agraf@suse.de on Thu Jan 31 06:04:29 2013)
Content-Disposition: inline
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 01/31/2013 06:04:29 AM, Alexander Graf wrote:
> 
> On 30.01.2013, at 12:12, Bhushan Bharat-R65777 wrote:
> 
> > On bookehv this is how I am controlling the MSR_DE in hardware MSR.
> >
> >> And why is this whole thing only executed on HV?
> >
> > On e500v2 we always enable MSR_DE using vcpu->arch.shadow_msr in  
> e500.c
> > #ifndef CONFIG_KVM_BOOKE_HV
> > -       vcpu->arch.shadow_msr = MSR_USER | MSR_IS | MSR_DS;
> > +       vcpu->arch.shadow_msr = MSR_USER | MSR_DE | MSR_IS | MSR_DS;
> 
> Why? How is e500v2 any different wrt debug? And why wouldn't that  
> work for e500mc?

shadow_msr isn't used at all on bookehv.

-Scott