Re: [PATCH V3 0/2] tcm_vhost hotplug/hotunplug support

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Mon, 2013-03-18 at 23:53 +0200, Michael S. Tsirkin wrote:
> On Mon, Mar 18, 2013 at 02:46:12PM -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2013-03-12 at 10:45 +0800, Asias He wrote:
> > > Changes in v3:
> > > - Separate the bug fix to another thread
> > > 
> > > Changes in v2:
> > > - Remove code duplication in tcm_vhost_{hotplug,hotunplug}
> > > - Fix racing of vs_events_nr
> > > - Add flush fix patch to this series
> > > 
> > > 
> > > Asias He (2):
> > >   tcm_vhost: Introduce tcm_vhost_check_feature()
> > >   tcm_vhost: Add hotplug/hotunplug support
> > > 
> > >  drivers/vhost/tcm_vhost.c | 224 ++++++++++++++++++++++++++++++++++++++++++++--
> > >  drivers/vhost/tcm_vhost.h |  10 +++
> > >  2 files changed, 229 insertions(+), 5 deletions(-)
> > > 
> > 
> > MST, are you OK with these two being applied to target-pending/for-next
> > now..?
> > 
> > --nab
> 
> Sorry, no, I'd prefer we get userspace support in qemu in first.
> If there's only a single user for this driver (kvmtool),
> then it was a mistake to merge it, the right thing would be to freeze it
> and look at whether we can drop it completely.
> 
> I really don't want this, I hope it will be merged and all will
> be shiny, but I think it's wrong to rush in more code,
> we have some time before the next merge window.
> 

Fair enough.

With the seabios issues now out of the way, the proposed vhost-scsi-pci
series from Paolo can make it's way into upstream QEMU in an expedited
fashion.

If Asias is OK with it, I'll take ownership of the WIP code and make
sure it finally makes it into upstream QEMU proper.

Thanks,

--nab