From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM Date: Wed, 20 Mar 2013 18:58:41 -0500 Message-ID: <1363823921.25034.35@snotra> References: <1363306426-27209-1-git-send-email-khilman@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Frederic Weisbecker , , Marcelo Tosatti , Gleb Natapov , "open list:KERNEL VIRTUAL MA..." , open list To: Kevin Hilman Return-path: Received: from co1ehsobe004.messaging.microsoft.com ([216.32.180.187]:59483 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676Ab3CTX6r convert rfc822-to-8bit (ORCPT ); Wed, 20 Mar 2013 19:58:47 -0400 In-Reply-To: <1363306426-27209-1-git-send-email-khilman@linaro.org> (from khilman@linaro.org on Thu Mar 14 19:13:46 2013) Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: > The new context tracking subsystem unconditionally includes kvm_host.h > headers for the guest enter/exit macros. This causes a compile > failure when KVM is not enabled. > > Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can > be included/compiled even when KVM is not enabled. > > Cc: Frederic Weisbecker > Signed-off-by: Kevin Hilman > --- > Applies on v3.9-rc2 > > include/linux/kvm_host.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) This broke the PPC non-KVM build, which was relying on stub functions in kvm_ppc.h, which relies on "struct vcpu" in kvm_host.h. Why can't the entirety kvm_host.h be included regardless of CONFIG_KVM, just like most other feature-specific headers? Why can't the if/else just go around the functions that you want to stub out for non-KVM builds? -Scott