From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [RFC PATCH 6/6] kvm/ppc/mpic: in-kernel MPIC emulation Date: Thu, 21 Mar 2013 09:43:01 -0500 Message-ID: <1363876981.31522.2@snotra> References: <1360820960-12537-1-git-send-email-scottwood@freescale.com> <1360820960-12537-7-git-send-email-scottwood@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: , To: Alexander Graf Return-path: Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:26452 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933582Ab3CUOnI convert rfc822-to-8bit (ORCPT ); Thu, 21 Mar 2013 10:43:08 -0400 In-Reply-To: (from agraf@suse.de on Thu Mar 21 03:28:35 2013) Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On 03/21/2013 03:28:35 AM, Alexander Graf wrote: > > On 14.02.2013, at 06:49, Scott Wood wrote: > > > Hook the MPIC code up to the KVM interfaces, add locking, etc. > > > > TODO: irqfd support > > > > Signed-off-by: Scott Wood > > Could you please split this patch up on your next respin? Any particular split you're looking for? The only reason it's split as much as it is already is to give some chance of merging updates from QEMU being less painful. As far as the kernel is concerned, this is new code, which is not functional (and thus not built) before this patch. There aren't meaningful intermediate states. > Also please make sure you don't have #if 0'ed code in here. Well, yeah. Note the RFC. :-) -Scott