From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Bug 55421] igb VF can't work in KVM guest
Date: Thu, 21 Mar 2013 15:31:58 -0600
Message-ID: <1363901518.14627.1.camel@ul30vt.home>
References: <bug-55421-28872@https.bugzilla.kernel.org/>
	 <20130321212909.537AC11F7D1@bugzilla.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: mitch.a.williams@intel.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:15107 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753425Ab3CUVcA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 21 Mar 2013 17:32:00 -0400
In-Reply-To: <20130321212909.537AC11F7D1@bugzilla.kernel.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mitch,

Bugzilla wouldn't let me add you to the CC, so FYI...
Thanks,

Alex

On Thu, 2013-03-21 at 21:29 +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=55421
> 
> 
> Alex Williamson <alex.williamson@redhat.com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |alex.williamson@redhat.com,
>                    |                            |jeffrey.t.kirsher@intel.com
> 
> 
> 
> 
> --- Comment #4 from Alex Williamson <alex.williamson@redhat.com>  2013-03-21 21:29:09 ---
> Further bisected to:
> 
> commit 5ac6f91d39e0884813dc010e14552143cd1d0d8b
> Author: Mitch A Williams <mitch.a.williams@intel.com>
> Date:   Fri Jan 18 08:57:20 2013 +0000
> 
>     igb: Don't give VFs random MAC addresses
> 
>     If the user has not assigned a MAC address to a VM, then don't give it a
>     random one. Instead, just give it zeros and let it figure out what to do
>     with them.
> 
>     Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
>     CC: Andy Gospodarek <andy@greyhouse.net>
>     CC: Stefan Assmann <sassmann@kpanic.de>
>     Tested-by: Aaron Brown <aaron.f.brown@intel.com>
>     Tested-by: Stefan Assmann <sassmann@redhat.com>
>     Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> So, for whatever reason we no longer assign a random MAC address when using the
> device in a VM (but we do still use one if attached to igbvf in the host).  I
> expect we'll eventually see this on all the Intel SR-IOV NICs.  The solution is
> to use the ip command to assign the VF a valid MAC address prior to using it
> with KVM.  I'll let those who made the change defend it further if they wish.
>