public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>, Asias He <asias@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	target-devel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin O'Connor <kevin@koconnor.net>,
	seabios-devel <seabios@seabios.org>
Subject: Re: [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check
Date: Thu, 28 Mar 2013 19:53:26 -0700	[thread overview]
Message-ID: <1364525606.10253.69.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <8300718.16452772.1364465611936.JavaMail.root@redhat.com>

On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote:
> > I think it's the right thing to do, but maybe not the right place
> > to do this, need to reset after all IO is done, before
> > ring memory is write protected.
> 
> Our emails are crossing each other unfortunately, but I want to
> reinforce this: ring memory is not write protected.

Understood.  However, AFAICT the act of write protecting these ranges
for ROM generates the offending callbacks to vhost_set_memory().

The part that I'm missing is if ring memory is not being write protected
by make_bios_readonly_intel(), why are the vhost_set_memory() calls
being invoked..?

> Remember that
> SeaBIOS can even provide virtio-scsi access to DOS, so you must
> not reset the device.  It must remain functional all the time,
> and the OS's own driver will reset it when it's started.
> 

Mmmm, so a vp_reset() is out of the question then..

--nab



  reply	other threads:[~2013-03-29  2:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19  0:34 [PATCH V3 WIP 0/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Asias He
2013-03-19  0:34 ` [PATCH V3 WIP 1/3] virtio-scsi: create VirtIOSCSICommon Asias He
2013-03-19  0:34 ` [PATCH V3 WIP 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Asias He
2013-03-19  8:40   ` Stefan Hajnoczi
2013-03-19  0:34 ` [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check Asias He
2013-03-19  8:40   ` Stefan Hajnoczi
2013-03-19  8:47     ` Asias He
2013-03-20  1:57     ` Nicholas A. Bellinger
2013-03-20  9:51       ` Michael S. Tsirkin
2013-03-27 21:31         ` Nicholas A. Bellinger
2013-03-27 21:56           ` Michael S. Tsirkin
2013-03-27 22:33             ` Nicholas A. Bellinger
2013-03-28  6:45               ` Nicholas A. Bellinger
2013-03-28  7:35                 ` Nicholas A. Bellinger
2013-03-28  9:04                   ` Michael S. Tsirkin
2013-03-28 10:03                     ` Paolo Bonzini
2013-03-29  2:47                       ` Nicholas A. Bellinger
2013-03-28 10:13                     ` Paolo Bonzini
2013-03-29  2:53                       ` Nicholas A. Bellinger [this message]
2013-03-29  8:14                         ` Paolo Bonzini
2013-04-02  1:05                           ` Nicholas A. Bellinger
2013-04-02 13:27                             ` Michael S. Tsirkin
2013-04-03  4:04                               ` Nicholas A. Bellinger
2013-04-03  4:59                                 ` Nicholas A. Bellinger
2013-04-03  6:47                                   ` Paolo Bonzini
2013-03-29  3:28                     ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364525606.10253.69.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=asias@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox