From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [RFC PATCH v2 1/6] kvm: add device control API Date: Wed, 3 Apr 2013 16:03:06 -0500 Message-ID: <1365022986.25627.12@snotra> References: <20130403010239.GC16115@drongo> <1364951996.8690.2@snotra> <20130403021758.GA17093@drongo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Alexander Graf , , To: Paul Mackerras Return-path: In-Reply-To: <20130403021758.GA17093@drongo> (from paulus@samba.org on Tue Apr 2 21:17:58 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/02/2013 09:17:58 PM, Paul Mackerras wrote: > On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: > > On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: > > >On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: > > >> +4.79 KVM_CREATE_DEVICE > > >> + > > >> +Capability: KVM_CAP_DEVICE_CTRL > > > > > >I notice this patch doesn't add this capability; > > > > Yes, it does (see below). > > > > >you add it in a later patch. > > > > Maybe you're thinking of KVM_CAP_IRQ_MPIC? > > No, I was referring to the addition to kvm_dev_ioctl_check_extension() > of a KVM_CAP_DEVICE_CTRL case. Since this patch adds the code to > handle > KVM_CREATE_DEVICE ioctl it should also add the code to return 1 if > userspace queries the KVM_CAP_DEVICE_CTRL capability. Ah. In that case we should probably recognize the capability in generic code rather than ppc code. -Scott