public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: Christoffer Dall <cdall@cs.columbia.edu>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 5/7] kvm/arm: Fix missing include build error
Date: Thu, 04 Apr 2013 17:04:57 -0700	[thread overview]
Message-ID: <1365120297.24496.32.camel@smoke> (raw)
In-Reply-To: <CAEDV+g+N9aJgEO2cQYrLSn6qmH-Tkio-A81bP6v6e7Stc4TbCQ@mail.gmail.com>

Hi Christoffer,

On Thu, 2013-04-04 at 16:51 -0700, Christoffer Dall wrote:
> On Thu, Apr 4, 2013 at 4:33 PM, Geoff Levand <geoff@infradead.org> wrote:
> > Include linux/cpu.h in kvm/arm.c.  Fixes build errors like
> > these with ARCH=arm64:
> >
> > arch/arm/kvm/arm.c: error: ‘CPU_STARTING_FROZEN’ undeclared
> >
> > Signed-off-by: Geoff Levand <geoff@infradead.org>
> > ---
> >  arch/arm/kvm/arm.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> > index 5a93698..49b4bc6 100644
> > --- a/arch/arm/kvm/arm.c
> > +++ b/arch/arm/kvm/arm.c
> > @@ -24,6 +24,7 @@
> >  #include <linux/fs.h>
> >  #include <linux/mman.h>
> >  #include <linux/sched.h>
> > +#include <linux/cpu.h>
> >  #include <linux/kvm.h>
> >  #include <trace/events/kvm.h>
> >
> > --
> >
> 
> I'm confused, I don't see this symbol in arm.c - against which tree do
> these patches apply exactly? If this is something introduced by arm64,
> then it's premature, and should be added to that series.

Sorry, this one is from Marc's kvm-for-next branch.  I'll send it
to him to include, unless you just want to take it in preparation.

-Geoff


  reply	other threads:[~2013-04-05  0:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 23:33 [PATCH 0/7] KVM minor fixups Geoff Levand
2013-04-04 23:33 ` [PATCH 1/7] kvm: Make local routines static Geoff Levand
2013-04-04 23:33 ` [PATCH 6/7] kvm/arm: Make force_vm_exit static Geoff Levand
2013-04-04 23:57   ` Christoffer Dall
2013-04-04 23:33 ` [PATCH 4/7] kvm: Move kvm_rebooting dec out of x86 Geoff Levand
2013-04-04 23:33 ` [PATCH 3/7] kvm: Move kvm_spurious_fault " Geoff Levand
2013-04-05  7:48   ` Paolo Bonzini
2013-04-05  7:56   ` Paolo Bonzini
2013-04-04 23:33 ` [PATCH 2/7] kvm: Move vm_list, kvm_lock dec's " Geoff Levand
2013-04-04 23:33 ` [PATCH 5/7] kvm/arm: Fix missing include build error Geoff Levand
2013-04-04 23:51   ` Christoffer Dall
2013-04-05  0:04     ` Geoff Levand [this message]
2013-04-05  0:15       ` Christoffer Dall
2013-04-05  0:24         ` Geoff Levand
2013-04-04 23:33 ` [PATCH 7/7] kvm/arm: Remove unused kvm_arch_set_memory_region Geoff Levand
2013-04-04 23:58   ` Christoffer Dall
2013-04-04 23:53 ` [PATCH 0/7] KVM minor fixups Christoffer Dall
2013-04-04 23:57   ` Geoff Levand
2013-04-05  0:01     ` Christoffer Dall
2013-04-05  7:56 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365120297.24496.32.camel@smoke \
    --to=geoff@infradead.org \
    --cc=cdall@cs.columbia.edu \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=marc.zyngier@arm.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox