From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [RFC PATCH v3 1/6] kvm: add device control API
Date: Mon, 8 Apr 2013 19:50:10 -0500
Message-ID: <1365468610.28843.29@snotra>
References: <20130408053313.GA8932@iris.ozlabs.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Transfer-Encoding: 8BIT
Cc: Alexander Graf <agraf@suse.de>, <kvm-ppc@vger.kernel.org>,
	<kvm@vger.kernel.org>
To: Paul Mackerras <paulus@samba.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20130408053313.GA8932@iris.ozlabs.ibm.com> (from
	paulus@samba.org on Mon Apr  8 00:33:13 2013)
Content-Disposition: inline
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 04/08/2013 12:33:13 AM, Paul Mackerras wrote:
> On Tue, Apr 02, 2013 at 08:57:48PM -0500, Scott Wood wrote:
> 
> [snip]
> 
> > +static int kvm_ioctl_create_device(struct kvm *kvm,
> > +				   struct kvm_create_device *cd)
> > +{
> > +	bool test = cd->flags & KVM_CREATE_DEVICE_TEST;
> > +
> > +	switch (cd->type) {
> > +	default:
> > +		return -ENODEV;
> > +	}
> > +}
> 
> This gives a compile error saying "error: unused variable `test'",
> which is fatal since this gets compiled under arch/powerpc/kvm, and we
> treat all warnings as errors there.
> 
> This still gives a compile error at the end of your series if you try
> to compile with CONFIG_KVM_MPIC=n.

Ah, right.  Will mark as __maybe_unused.

-Scott