public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: PPC: emulate dcbst
@ 2013-04-09 20:36 Stuart Yoder
  2013-04-10  3:20 ` Yoder Stuart-B08248
  2013-04-10 22:02 ` Alexander Graf
  0 siblings, 2 replies; 4+ messages in thread
From: Stuart Yoder @ 2013-04-09 20:36 UTC (permalink / raw)
  To: agraf; +Cc: kvm-ppc, kvm, Stuart Yoder

From: Stuart Yoder <stuart.yoder@freescale.com>

Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
 arch/powerpc/kvm/emulate.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index 7a73b6f..631a265 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -38,6 +38,7 @@
 
 #define OP_31_XOP_TRAP      4
 #define OP_31_XOP_LWZX      23
+#define OP_31_XOP_DCBST     54
 #define OP_31_XOP_TRAP_64   68
 #define OP_31_XOP_DCBF      86
 #define OP_31_XOP_LBZX      87
@@ -370,6 +371,7 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 			emulated = kvmppc_emulate_mtspr(vcpu, sprn, rs);
 			break;
 
+		case OP_31_XOP_DCBST:
 		case OP_31_XOP_DCBF:
 		case OP_31_XOP_DCBI:
 			/* Do nothing. The guest is performing dcbi because
-- 
1.7.9.7



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] KVM: PPC: emulate dcbst
  2013-04-09 20:36 [PATCH] KVM: PPC: emulate dcbst Stuart Yoder
@ 2013-04-10  3:20 ` Yoder Stuart-B08248
  2013-04-10 16:03   ` Scott Wood
  2013-04-10 22:02 ` Alexander Graf
  1 sibling, 1 reply; 4+ messages in thread
From: Yoder Stuart-B08248 @ 2013-04-10  3:20 UTC (permalink / raw)
  To: agraf@suse.de; +Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org

> -----Original Message-----
> From: Yoder Stuart-B08248
> Sent: Tuesday, April 09, 2013 3:36 PM
> To: agraf@suse.de
> Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Yoder Stuart-B08248
> Subject: [PATCH] KVM: PPC: emulate dcbst
> 
> From: Stuart Yoder <stuart.yoder@freescale.com>
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> ---

One thing I should have mentioned...without this patch
on the host 64-bit guest kernels are currently broken
when using -smp.  Not sure how far back things are broken,
the oldest kernel I had a chance to try was like 3.8-rc3.

Stuart

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: PPC: emulate dcbst
  2013-04-10  3:20 ` Yoder Stuart-B08248
@ 2013-04-10 16:03   ` Scott Wood
  0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2013-04-10 16:03 UTC (permalink / raw)
  To: Yoder Stuart-B08248
  Cc: agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org

On 04/09/2013 10:20:41 PM, Yoder Stuart-B08248 wrote:
> > -----Original Message-----
> > From: Yoder Stuart-B08248
> > Sent: Tuesday, April 09, 2013 3:36 PM
> > To: agraf@suse.de
> > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; Yoder  
> Stuart-B08248
> > Subject: [PATCH] KVM: PPC: emulate dcbst
> >
> > From: Stuart Yoder <stuart.yoder@freescale.com>
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
> > ---
> 
> One thing I should have mentioned...without this patch
> on the host 64-bit guest kernels are currently broken
> when using -smp.  Not sure how far back things are broken,
> the oldest kernel I had a chance to try was like 3.8-rc3.

It's due to dcbst being used on the spin table, which is treated as  
emulated MMIO under QEMU.

-Scott

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: PPC: emulate dcbst
  2013-04-09 20:36 [PATCH] KVM: PPC: emulate dcbst Stuart Yoder
  2013-04-10  3:20 ` Yoder Stuart-B08248
@ 2013-04-10 22:02 ` Alexander Graf
  1 sibling, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2013-04-10 22:02 UTC (permalink / raw)
  To: Stuart Yoder; +Cc: kvm-ppc, kvm


On 09.04.2013, at 22:36, Stuart Yoder wrote:

> From: Stuart Yoder <stuart.yoder@freescale.com>
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>

Thanks, applied to kvm-ppc-queue.


Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-10 22:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-09 20:36 [PATCH] KVM: PPC: emulate dcbst Stuart Yoder
2013-04-10  3:20 ` Yoder Stuart-B08248
2013-04-10 16:03   ` Scott Wood
2013-04-10 22:02 ` Alexander Graf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox