From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC
Date: Mon, 15 Apr 2013 12:52:27 -0500
Message-ID: <1366048347.15365.1@snotra>
References: <1364954273-18196-1-git-send-email-scottwood@freescale.com>
	<1365811727-24431-1-git-send-email-scottwood@freescale.com>
	<1365811727-24431-7-git-send-email-scottwood@freescale.com>
	<20130415052328.GC7494@iris.ozlabs.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Transfer-Encoding: 8BIT
Cc: Alexander Graf <agraf@suse.de>, <kvm-ppc@vger.kernel.org>,
	<kvm@vger.kernel.org>
To: Paul Mackerras <paulus@samba.org>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <20130415052328.GC7494@iris.ozlabs.ibm.com> (from
	paulus@samba.org on Mon Apr 15 00:23:28 2013)
Content-Disposition: inline
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 04/15/2013 12:23:28 AM, Paul Mackerras wrote:
> On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote:
> > Enabling this capability connects the vcpu to the designated  
> in-kernel
> > MPIC.  Using explicit connections between vcpus and irqchips allows
> > for flexibility, but the main benefit at the moment is that it
> > simplifies the code -- KVM doesn't need vm-global state to remember
> > which MPIC object is associated with this vm, and it doesn't need to
> > care about ordering between irqchip creation and vcpu creation.
> 
> This fails to link with CONFIG_KVM_MPIC=n with the following error:
> 
> arch/powerpc/kvm/built-in.o: In function `.kvm_arch_vcpu_free':
> (.text+0x94f0): undefined reference to `.kvmppc_mpic_disconnect_vcpu'

Sigh, forgot the ifdef again. :-(

-Scott