From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs Date: Fri, 3 May 2013 15:15:01 -0500 Message-ID: <1367612101.19391.8@snotra> References: <1367597470-22214-1-git-send-email-mihai.caraman@freescale.com> <1367604287.19391.2@snotra> <300B73AA675FCE4A93EB4FC1D42459FF3E984C@039-SN2MPN1-013.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="Flowed"; DelSp="Yes" Content-Transfer-Encoding: 7bit Cc: Wood Scott-B07421 , "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , "kvm-ppc@vger.kernel.org" To: Caraman Mihai Claudiu-B02008 Return-path: In-Reply-To: <300B73AA675FCE4A93EB4FC1D42459FF3E984C@039-SN2MPN1-013.039d.mgd.msft.net> (from B02008@freescale.com on Fri May 3 15:01:26 2013) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org On 05/03/2013 03:01:26 PM, Caraman Mihai Claudiu-B02008 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, May 03, 2013 9:05 PM > > To: Caraman Mihai Claudiu-B02008 > > Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > > dev@lists.ozlabs.org; Caraman Mihai Claudiu-B02008 > > Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and > hangs > > > > > The unresponsiveness has to do with the fact that > > > arch_local_irq_restore() > > > does not guarantees to hard enable interrupts. > > > > Could you elaborate? If the saved IRQ state was "enabled", why > > wouldn't arch_local_irq_restore() hard-enable IRQs? The last thing > it > > does is __hard_irq_enable(). > > if (!irq_happened) > return; OK, so the problem is that we're not setting PACA_IRQ_HARD_DIS when we hard-disable interrupts? > > Where is the arch_local_irq_restore() instance you're talking about? > > ./arch/power/kernel/irq.c I meant the caller. :-P -Scott