From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs Date: Sat, 04 May 2013 08:03:30 +1000 Message-ID: <1367618610.4389.119.camel@pasglop> References: <1367597470-22214-1-git-send-email-mihai.caraman@freescale.com> <981DB739-E50F-488F-B2D8-916FDC2E1749@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Mihai Caraman , kvm-ppc@vger.kernel.org, "kvm@vger.kernel.org VIRTUAL MA..." , linuxppc-dev@lists.ozlabs.org To: Alexander Graf Return-path: In-Reply-To: <981DB739-E50F-488F-B2D8-916FDC2E1749@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, 2013-05-03 at 18:24 +0200, Alexander Graf wrote: > > There is no reason to exit guest with soft_enabled == 1, a local_irq_enable() > > call will do this for us so get rid of kvmppc_layz_ee() calls. With this fix > > we eliminate irqs_disabled() warnings and some guest and host hangs revealed > > under stress tests, but guests still exhibit some unresponsiveness. > > > > The unresponsiveness has to do with the fact that arch_local_irq_restore() > > does not guarantees to hard enable interrupts. To do so replace exception > > function calls like timer_interrupt() with irq_happened flags. The > > local_irq_enable() call takes care of replaying them and lets the interrupts > > hard enabled. > > > > Signed-off-by: Mihai Caraman > > Ben, could you please review? That does look like the right thing to do indeed. Acked-by: Benjamin Herrenschmidt Cheers, Ben.