From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH] kvm/ppc/booke64: Hard disable interrupts when entering the guest Date: Fri, 3 May 2013 18:53:47 -0500 Message-ID: <1367625227.19391.16@snotra> References: <1367624723-22456-1-git-send-email-scottwood@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Alexander Graf , , , , Mihai Caraman To: Scott Wood Return-path: In-Reply-To: <1367624723-22456-1-git-send-email-scottwood@freescale.com> (from scottwood@freescale.com on Fri May 3 18:45:23 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/03/2013 06:45:23 PM, Scott Wood wrote: > While we could just set PACA_IRQ_HARD_DIS after an exit to compensate, > instead hard-disable interrupts before entering the guest. This way, > we won't have to worry about interactions if we take an interrupt > during the guest entry code. While I don't see any obvious > interactions, it could change in the future (e.g. it would be bad if > the non-hv code were used on 64-bit or if 32-bit guest lazy interrupt > disabling, since the non-hv code changes IVPR among other things). s/32-bit guest lazy/32-bit gets lazy/ -Scott