From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] kvm/ppc: interrupt disabling fixes
Date: Wed, 08 May 2013 06:23:24 +1000
Message-ID: <1367958204.25488.14.camel@pasglop>
References: <1367953139.3398.28@snotra>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: "tiejun.chen" <tiejun.chen@windriver.com>,
	Alexander Graf <agraf@suse.de>, kvm-ppc@vger.kernel.org,
	kvm@vger.kernel.org, Mihai Caraman <mihai.caraman@freescale.com>,
	Paul Mackerras <paulus@au1.ibm.com>
To: Scott Wood <scottwood@freescale.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from gate.crashing.org ([63.228.1.57]:56550 "EHLO gate.crashing.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753601Ab3EGUXl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 May 2013 16:23:41 -0400
In-Reply-To: <1367953139.3398.28@snotra>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, 2013-05-07 at 13:58 -0500, Scott Wood wrote:
> This will have to wait until book3s_hv disables interrupts as well.  If  
> this does eventually happen, then the  
> local_irq_enable()/kvmppc_lazy_ee_enable() should also probably go into  
> kvmppc_prepare_to_enter() -- though that could cause problems in  
> book3s_pr, if it's depending on the kvmppc_lazy_ee_enable() happening  
> as late as it does.

Is book3s calling prepare_to_enter at all ? It has its own things with
no interrupt disabling which afaik is racy vs. checking for signals & resched...

(CC'ing Paul).

BTW. Linus just pulled my tree which contains my changed to hard_irq_disable()
to do the trace_hardirqs_off() when neeed.

Cheers,
Ben.