From: Vadim Rozenfeld <vrozenfe@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
kvm@vger.kernel.org, mtosatti@redhat.com, pl@dlh.net
Subject: Re: [RFC PATCH 1/2] Hyper-H reference counter
Date: Fri, 17 May 2013 00:22:11 +1000 [thread overview]
Message-ID: <1368714131.18400.11.camel@localhost> (raw)
In-Reply-To: <5194E105.8000909@redhat.com>
On Thu, 2013-05-16 at 15:37 +0200, Paolo Bonzini wrote:
> Il 16/05/2013 11:28, Vadim Rozenfeld ha scritto:
> >>>>> > > > > + case HV_X64_MSR_REFERENCE_TSC: {
> >>>>> > > > > + u64 gfn;
> >>>>> > > > > + unsigned long addr;
> >>>>> > > > > + u32 tsc_ref;
> >>>>> > > > > + gfn = data >> HV_X64_MSR_HYPERCALL_PAGE_ADDRESS_SHIFT;
> >>>> > > > Shouldn't you check HV_X64_MSR_TSC_REFERENCE_ENABLE here?
> >>> > >
> >>> > > Yes, I have this check added in the second patch.
> >>> > >
> >> > Move it here please.
> > OK, will do it.
> >> >
> >>>> > > >
> >>>>> > > > > + addr = gfn_to_hva(kvm, gfn);
> >>>>> > > > > + if (kvm_is_error_hva(addr))
> >>>>> > > > > + return 1;
> >>>>> > > > > + tsc_ref = 0;
>
> This should write 0xFFFFFFFF.
This should write 0
Vadim.
>
> Paolo
next prev parent reply other threads:[~2013-05-16 14:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 11:45 [RFC PATCH 0/2] Hyper-V timers Vadim Rozenfeld
2013-05-13 11:45 ` [RFC PATCH 1/2] Hyper-H reference counter Vadim Rozenfeld
2013-05-13 23:30 ` Eric Northup
2013-05-14 9:46 ` Vadim Rozenfeld
2013-05-16 8:18 ` Gleb Natapov
2013-05-16 8:53 ` Vadim Rozenfeld
2013-05-14 14:14 ` Peter Lieven
2013-05-15 10:24 ` Vadim Rozenfeld
2013-05-16 8:10 ` Gleb Natapov
2013-05-16 8:34 ` Gleb Natapov
2013-05-16 9:13 ` Vadim Rozenfeld
2013-05-16 9:21 ` Gleb Natapov
2013-05-16 9:28 ` Vadim Rozenfeld
2013-05-16 13:37 ` Paolo Bonzini
2013-05-16 14:22 ` Vadim Rozenfeld [this message]
2013-05-16 14:48 ` Paolo Bonzini
2013-05-16 13:44 ` Paolo Bonzini
2013-05-16 14:26 ` Vadim Rozenfeld
2013-05-16 14:45 ` Paolo Bonzini
2013-05-19 6:37 ` Vadim Rozenfeld
2013-05-20 8:05 ` Paolo Bonzini
2013-05-20 8:36 ` Gleb Natapov
2013-05-20 8:42 ` Paolo Bonzini
2013-05-20 8:49 ` Gleb Natapov
2013-05-20 8:56 ` Paolo Bonzini
2013-05-20 9:13 ` Gleb Natapov
2013-05-20 9:25 ` Gleb Natapov
2013-05-20 9:32 ` Paolo Bonzini
2013-05-20 9:41 ` Gleb Natapov
2013-05-20 10:06 ` Peter Lieven
2013-05-20 10:25 ` Vadim Rozenfeld
2013-05-20 10:27 ` Gleb Natapov
2013-05-20 10:44 ` Vadim Rozenfeld
2013-05-20 10:21 ` Vadim Rozenfeld
2013-05-20 9:12 ` Vadim Rozenfeld
2013-05-16 14:40 ` Paolo Bonzini
2013-05-13 11:45 ` [RFC PATCH 2/2] Hyper-V iTSC handler Vadim Rozenfeld
2013-05-16 8:33 ` Gleb Natapov
2013-05-16 8:58 ` Vadim Rozenfeld
2013-05-16 8:02 ` [RFC PATCH 0/2] Hyper-V timers Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368714131.18400.11.camel@localhost \
--to=vrozenfe@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@dlh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).