From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vadim Rozenfeld Subject: Re: [RFC PATCH 1/2] Hyper-H reference counter Date: Mon, 20 May 2013 19:12:25 +1000 Message-ID: <1369041145.31632.1.camel@localhost> References: <1368445517-5496-1-git-send-email-vrozenfe@redhat.com> <1368445517-5496-2-git-send-email-vrozenfe@redhat.com> <20130516083450.GM26453@redhat.com> <1368695621.18400.9.camel@localhost> <20130516092128.GP26453@redhat.com> <1368696535.18400.10.camel@localhost> <5194E2D3.3080300@redhat.com> <1368714390.18400.13.camel@localhost> <5194F0F8.9070205@redhat.com> <1368945475.1859.2.camel@localhost> <5199D952.2020808@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, mtosatti@redhat.com, pl@dlh.net To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45977 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752058Ab3ETJMi (ORCPT ); Mon, 20 May 2013 05:12:38 -0400 In-Reply-To: <5199D952.2020808@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2013-05-20 at 10:05 +0200, Paolo Bonzini wrote: > Il 19/05/2013 08:37, Vadim Rozenfeld ha scritto: > > On Thu, 2013-05-16 at 16:45 +0200, Paolo Bonzini wrote: > >> Il 16/05/2013 16:26, Vadim Rozenfeld ha scritto: > >>>>>>>>>>> > >>>>>>>>>>> Yes, I have this check added in the second patch. > >>>>>>>>>>> > >>>>>>>>> Move it here please. > >>>>>>> OK, will do it. > >>>>> > >>>>> Or better, remove all the handling of HV_X64_MSR_REFERENCE_TSC from this > >>>>> patch, and leave it all to the second. > >>>>> > >>> What for? Could you please elaborate? > > > > To make code reviewable. Add one MSR here, the other in the second patch. > > removing HV_X64_MSR_REFERENCE_TSC will make this particular patch > > completely non-functional. > > Do you mean Windows guest will BSOD or just that they won't use the > reference TSC? If the latter, it's not a problem. Unfortunately, it will crash. > > Paolo