From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling Date: Wed, 29 May 2013 15:05:49 -0500 Message-ID: <1369857949.18630.42@snotra> References: <1369763138.18630.3@snotra> <51A53E20.3020205@ozlabs.ru> <1369784115.18630.27@snotra> <51A547F0.8090406@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: David Gibson , , , , Alexander Graf , Paul Mackerras , To: Alexey Kardashevskiy Return-path: In-Reply-To: <51A547F0.8090406@ozlabs.ru> (from aik@ozlabs.ru on Tue May 28 19:12:32 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/28/2013 07:12:32 PM, Alexey Kardashevskiy wrote: > On 05/29/2013 09:35 AM, Scott Wood wrote: > > On 05/28/2013 06:30:40 PM, Alexey Kardashevskiy wrote: > >> >> >>> @@ -939,6 +940,9 @@ struct kvm_s390_ucas_mapping { > >> >> >>> #define KVM_GET_DEVICE_ATTR _IOW(KVMIO, 0xe2, struct > >> >> >>> kvm_device_attr) > >> >> >>> #define KVM_HAS_DEVICE_ATTR _IOW(KVMIO, 0xe3, struct > >> >> >>> kvm_device_attr) > >> >> >>> > >> >> >>> +/* ioctl for SPAPR TCE IOMMU */ > >> >> >>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xe4, > struct > >> >> >>> kvm_create_spapr_tce_iommu) > >> >> >> > >> >> >> Shouldn't this go under the vm ioctl section? > >> >> > >> >> > >> >> The KVM_CREATE_SPAPR_TCE_IOMMU ioctl (the version for emulated > >> devices) is > >> >> in this section so I decided to keep them together. Wrong? > >> > > >> > You decided to keep KVM_CREATE_SPAPR_TCE_IOMMU together with > >> > KVM_CREATE_SPAPR_TCE_IOMMU? > >> > >> Yes. > > > > Sigh. That's the same thing repeated. There's only one IOCTL. > Nothing is > > being "kept together". > > Sorry, I meant this ioctl - KVM_CREATE_SPAPR_TCE. But you didn't put it in the same section as KVM_CREATE_SPAPR_TCE. 0xe0 begins a different section. -Scott