From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17D60185955; Wed, 13 Nov 2024 21:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731534114; cv=none; b=NcqgZXeDEHYTBqLT5AdVskBBrFtaJTSPuI51iwKJg0BxjSjsfjSOlOPtIQ3LHUsZCiVLu+wHh3Dyfpcm8eASy4aCT8tXwb7eFu/Ud7ZLBR12io0/eaM5lgflKZJLdbesF4U5vH7x7hCeS0yaIOH+R4yL0/IPXFs/ztSwT1gRzxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731534114; c=relaxed/simple; bh=IlTgVSRgld4+cTuexGuIhZnHcLpAHlpFZ0vuU4J+n3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VKpU8WxdcxomSu+28moXgZrDgmnyZ3QI+4dK1Igj1eCspJv5oBd4c5VSJC++v+7EKUbmoqpZ60uR/NlAjv+bDs3UdX/H9O8cjoOefXEVJNqolaXSYrvHHMoBQapj+AmMJ+JrKV7EdMCi4U3xjMWnqFa2o2cNt81AD+OxJGuw3NQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FtxSJkGI; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FtxSJkGI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731534112; x=1763070112; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IlTgVSRgld4+cTuexGuIhZnHcLpAHlpFZ0vuU4J+n3M=; b=FtxSJkGIE7uNBKhzJRVZgcS/cFhq3txVABG+akrrCZGld2bR/Gar29QB dl9MZYlm3X7rcwebWp3mJZmv87MhqrebjjXhvpjhnZBcbvHDFH4fYIHZS cdQOLk8R1vndi+6bJ6ZjnubRZCkAXnjOuKVVOCKcnRaJ4Eiltn3dds+LH 4Mk5BowcVfiHZ2WciiZ8EOJG8dMtCYlH+QhEeeUdZajVJUoNca6iQw389 NzwjMj/DQzFrFteOC/NMrNwBuYq12l6+8EkIqRYXG7Y/QXUS2OMGbQsiO 0hNeWeMLtIywoyRvz6T/8Cw5jat83fPo+giVOq77U6ZxC2e7cwoJcyqmO Q==; X-CSE-ConnectionGUID: Eiv8OtkFTBCXtKId4ZEwAg== X-CSE-MsgGUID: pwDDmtRDS3SJ3DMgS0RKIw== X-IronPort-AV: E=McAfee;i="6700,10204,11254"; a="35244576" X-IronPort-AV: E=Sophos;i="6.12,152,1728975600"; d="scan'208";a="35244576" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2024 13:41:52 -0800 X-CSE-ConnectionGUID: jXQh6KNyS7KXs0ANjrQncA== X-CSE-MsgGUID: /JGajjMbSLOsxMXl5yAKgg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,152,1728975600"; d="scan'208";a="92939523" Received: from kkkuntal-desk3 (HELO [10.124.220.196]) ([10.124.220.196]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2024 13:41:50 -0800 Message-ID: <136df713-64f1-4dfb-90c2-88c613fc72a7@intel.com> Date: Wed, 13 Nov 2024 13:41:50 -0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/25] x86/virt/tdx: Add SEAMCALL wrappers for TDX flush operations To: "Edgecombe, Rick P" , "pbonzini@redhat.com" , "seanjc@google.com" Cc: "sean.j.christopherson@intel.com" , "Yao, Yuan" , "Huang, Kai" , "binbin.wu@linux.intel.com" , "Li, Xiaoyao" , "isaku.yamahata@gmail.com" , "linux-kernel@vger.kernel.org" , "tony.lindgren@linux.intel.com" , "kvm@vger.kernel.org" , "Zhao, Yan Y" , "Chatre, Reinette" , "Yamahata, Isaku" References: <20241030190039.77971-1-rick.p.edgecombe@intel.com> <20241030190039.77971-11-rick.p.edgecombe@intel.com> <977e362f-bd0b-4653-8d47-c369b71c7dda@intel.com> <966fcd7dc3b298935b4aa9b476d712eefa9fabbf.camel@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <966fcd7dc3b298935b4aa9b476d712eefa9fabbf.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/13/24 13:18, Edgecombe, Rick P wrote: > -u64 tdh_vp_flush(u64 tdvpr) > +u64 tdh_vp_flush(void *tdvpr) > { > struct tdx_module_args args = { > - .rcx = tdvpr, > + .rcx = __pa(tdvpr), > }; > > return seamcall(TDH_VP_FLUSH, &args); I'd much rather these be: tdx->tdvpr_page = alloc_page(GFP_KERNEL_ACCOUNT); and then you pass around the struct page and do: .rcx = page_to_phys(tdvpr) Because it's honestly _not_ an address. It really and truly is a page and you never need to dereference it, only pass it around as a handle. You could get fancy and make a typedef for it or something, or even struct tdvpr_struct { struct page *page; } But that's probably overkill. It would help to, for instance, avoid mixing up these two pages: +u64 tdh_vp_create(u64 tdr, u64 tdvpr); But it wouldn't help as much for these: +u64 tdh_vp_addcx(u64 tdvpr, u64 tdcx); +u64 tdh_vp_init(u64 tdvpr, u64 initial_rcx); +u64 tdh_vp_init_apicid(u64 tdvpr, u64 initial_rcx, u32 x2apicid); +u64 tdh_vp_flush(u64 tdvpr); +u64 tdh_vp_rd(u64 tdvpr, u64 field, u64 *data); +u64 tdh_vp_wr(u64 tdvpr, u64 field, u64 data, u64 mask); Except for (for instance) 'tdr' vs. 'tdvpr' confusion. Spot the bug: tdh_vp_flush(kvm_tdx(foo)->tdr_pa); tdh_vp_flush(kvm_tdx(foo)->tdrvp_pa); Do you want the compiler's help for those?