From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [RFC PATCH 5/6] KVM: PPC: Book3E: Add ONE_REG AltiVec support Date: Tue, 4 Jun 2013 17:40:22 -0500 Message-ID: <1370385622.748.21@snotra> References: <1370292868-2697-1-git-send-email-mihai.caraman@freescale.com> <1370292868-2697-6-git-send-email-mihai.caraman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: , , , Mihai Caraman To: Mihai Caraman Return-path: Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:56684 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811Ab3FDWk3 convert rfc822-to-8bit (ORCPT ); Tue, 4 Jun 2013 18:40:29 -0400 In-Reply-To: <1370292868-2697-6-git-send-email-mihai.caraman@freescale.com> (from mihai.caraman@freescale.com on Mon Jun 3 15:54:27 2013) Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On 06/03/2013 03:54:27 PM, Mihai Caraman wrote: > Add ONE_REG support for AltiVec on Book3E. > > Signed-off-by: Mihai Caraman > --- > arch/powerpc/kvm/booke.c | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 01eb635..019496d 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -1570,6 +1570,22 @@ int kvm_vcpu_ioctl_get_one_reg(struct kvm_vcpu > *vcpu, struct kvm_one_reg *reg) > case KVM_REG_PPC_DEBUG_INST: > val = get_reg_val(reg->id, KVMPPC_INST_EHPRIV); > break; > +#ifdef CONFIG_ALTIVEC > + case KVM_REG_PPC_VR0 ... KVM_REG_PPC_VR31: > + if (!cpu_has_feature(CPU_FTR_ALTIVEC)) { > + r = -ENXIO; > + break; > + } > + val.vval = vcpu->arch.vr[reg->id - KVM_REG_PPC_VR0]; > + break; > + case KVM_REG_PPC_VSCR: > + if (!cpu_has_feature(CPU_FTR_ALTIVEC)) { > + r = -ENXIO; > + break; > + } > + val = get_reg_val(reg->id, vcpu->arch.vscr.u[3]); > + break; Why u[3]? -Scott