From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH] kvm tools: fix boot of guests with more than 4gb of ram Date: Tue, 25 Jun 2013 10:58:12 +1000 Message-ID: <1372121892.11276.2.camel@concordia> References: <1372037011-19466-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, will.deacon@arm.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from ozlabs.org ([203.10.76.45]:58066 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427Ab3FYA6U (ORCPT ); Mon, 24 Jun 2013 20:58:20 -0400 In-Reply-To: <1372037011-19466-1-git-send-email-sasha.levin@oracle.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2013-06-23 at 21:23 -0400, Sasha Levin wrote: > Commit "kvm tools: virtio: remove hardcoded assumptions > about guest page size" has introduced a bug that prevented > guests with more than 4gb of ram from booting. > > The issue is that 'pfn' is a 32bit integer, so when multiplying > it by page size to get the actual page will cause an overflow if > the pfn referred to a memory area above 4gb. Couldn't we just make pfn 64 bit? cheers